Skip to content

Introduce a UBI9 builder#583

Merged
maltesander merged 16 commits intomainfrom
ubi9-builder
May 6, 2024
Merged

Introduce a UBI9 builder#583
maltesander merged 16 commits intomainfrom
ubi9-builder

Conversation

@lfrancke
Copy link
Copy Markdown
Member

@lfrancke lfrancke commented Mar 2, 2024

Description

Please add a description here.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Does your change affect an SBOM? Make sure to update all SBOMs

Maleware
Maleware reviewed Mar 20, 2024
View reviewed changes
Comment thread ubi9-rust-builder/Dockerfile Outdated
@lfrancke lfrancke marked this pull request as ready for review May 2, 2024 08:13
@lfrancke lfrancke requested a review from Maleware May 2, 2024 08:14
@lfrancke lfrancke mentioned this pull request May 2, 2024
Closed
@lfrancke lfrancke self-assigned this May 2, 2024
soenkeliebau
soenkeliebau reviewed May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just three tiny things I noticed when looking over the pr

Comment thread ubi9-rust-builder/copy_artifacts.sh Outdated
Comment thread ubi9-rust-builder/Dockerfile Outdated
Comment thread ubi9-rust-builder/Dockerfile Outdated
maltesander
maltesander approved these changes May 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maltesander maltesander added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 8df36f0 May 6, 2024
@maltesander maltesander deleted the ubi9-builder branch May 6, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soenkeliebau soenkeliebau soenkeliebau left review comments

@maltesander maltesander maltesander approved these changes

@Maleware Maleware Awaiting requested review from Maleware

Assignees

@lfrancke lfrancke

Labels

release/24.7.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lfrancke @soenkeliebau @maltesander @Maleware